follow arduino API: pure virtual Stream::flush() moved to empty virtual Print::flush()#4029
Merged
devyte merged 3 commits intoesp8266:masterfrom Dec 29, 2017
Merged
follow arduino API: pure virtual Stream::flush() moved to empty virtual Print::flush()#4029devyte merged 3 commits intoesp8266:masterfrom
devyte merged 3 commits intoesp8266:masterfrom
Conversation
…al Print::flush() re fix esp8266#4018
Member
|
Looks like Print is also missing the virtual destructor... wonder why the compiler isn't warning about this. Change looks good though. |
Collaborator
Author
|
I guess that's because all arduino classes are generally global variables not dynamically allocated. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re fix #4018
::flush() declaration are now exactly the same as arduino's
flush added
flush removed